chore: venderダウンロード時、retryFetchでエラーになったときもリトライするように変更 #2616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 プレビュー用ページを作成しました 🚀 更新時点でのコミットハッシュ： |
nanae772
reviewed
Mar 16, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves the retry mechanism during vendor downloads by ensuring that errors thrown during fetch requests are caught and logged, so that the operation can be retried.
- Added a try-catch around the fetch call in the retry loop
- Modified error logging for fetch failures
Comments suppressed due to low confidence (1)
tools/helper.mts:23
- The final fetch call is not wrapped in a try-catch block, which might lead to unhandled errors if the request fails. Consider wrapping it in a try block to maintain consistent error handling throughout the function.
return fetch(url, options);
Hiroshiba
commented
Mar 16, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the retryFetch function to ensure that a network error or a non-OK response from fetch leads to a retry attempt.
- The for loop is modified to iterate one additional time by changing the loop condition.
- A try/catch block is added to handle errors from fetch and log them properly.
Comments suppressed due to low confidence (1)
tools/helper.mts:11
- With the current change, the loop attempts fetch 'retries' times and then calls fetch one additional time after the loop, resulting in a total of retries+1 attempts. Consider adjusting the logic to ensure the total number of attempts matches the intended retry count.
for (let i = 0; i < retries; i++) {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
chore: venderダウンロード時、retryFetchでエラーになったときもリトライするように変更
関連 Issue
スクリーンショット・動画など
その他